emulation station with vlc support to videos in themes ?

jackalpret

Hi, do you have plans to upgrade emulationstation to have vlc support for themes with video previews like OLD ROOM ?

https://retropie.org.uk/forum/topic/8019/oldroom-theme-w-i-p-new-1-9-beta-media-packs

nadenislamarre

this is not in my todo list, but any contribution to integrate that is welcome.

jackalpret

nadenislamarre when i finish my pendrive (cleaning roms that doesnt work and fixing images, etc) i will research and try 😉

jackalpret

nadenislamarre could you share your todo list ? features of course 🙂

best regards

nadenislamarre

note that thanks to git, you can easyly cherry-pick some commits for other emulationstation branches.
however, it will probably require more work.
my todo list is not understandable by anybody else than i.

jackalpret

nadenislamarre Do you use compiled version of emulationstation or make your own to use in batocera ?
Because here are the mods in emulationstation code to include VLC to play videos :
https://github.com/fieldofcows/EmulationStation/commit/25e1067794760523a331c07c1c0b23922b9644f2

If you can add this to the next version I could make a theme to reproduce videos and include it on batocera

nadenislamarre

@jackalpret i managed to merge it. i've still some things to do to be sure it will not make es crash.
do you have a ready test theme + 1 video + 1 game to confirm it works please ?

jackalpret

nadenislamarre I have a theme with video and game to test and try. old room theme.
i use 64 bits version of batocera

nadenislamarre

@jackalpret it make es crash. so, it requires to take time on it. as told, i won't take time on it for the moment. Moreover, it seems not simple to add video and to use for standard users.
You can work on the subject if wanted and do the merge (that have some conflicts) like this :

git clone https://github.com/nadenislamarre/recalbox-emulationstation
cd recalbox-emulationstation
cmake .
make
git remote add fieldofcows https://github.com/fieldofcows/EmulationStation.git
git fetch fieldofcows
git cherry-pick 25e1067794760523a331c07c1c0b23922b9644f2

jackalpret

nadenislamarre right, and what next ? after merge (cherry pick) ... compile again ? and how create the image to put in usb ?

nadenislamarre

compile again and run on your local computer.

if you want to run it on a batocera, i explain below my general way of working to work only on 1 package without rebuilding everything.
use this forum or ask susan on irc when i'm connected if you have any question on the way to work efficiently.

1) first build a batocera (see the wiki), in 2 words:
git clone
make recalbox-x86_64_defconfig
make

2) change packages/recalbox-emulation2/recalbox-emulation2.mk to point on your local git with modifications

3) remove the current build :
rm -rf output/build/recalbox-emulationstation2-rx5.0
mv output/target output/target_
mkdir output/target
make recalbox-emulationstation2
you can modify output/build/recalbox-es2 sources directly, and remove .stamp_build/.stamp_install_target then run again make recalbox-emulationstation2
build file are put in the new almost empty output/target,
start your batocera,
stop emulation : /etc/init.d/S31emulationstation stop
mount -o remount,rw /
rsync -av output/target/ root@recalbox.local:/
/etc/init.d/S31emulationstation start
eventually, save the overlay so that files are not removed after a reboot, /recalbox/script/recalbox-savexxx.sh

eventually, to remake a new image :
rm -rf output/build/recalbox-emulationstation2-rx5.0
make # this will rebuild es and remake the image

jackalpret

i couldnt check at the moment