RetroFlag case - Advanced Safe Shutdown

[deleted]

bandabanda That is possible.
edit script with nano /recalbox/share/scripts/recalbox_SafeShutdown.py

and change line 54/55 to ...

 		elif output:
os.system(scriptDir + "/recalbox_SafeShutdown.sh --kodi")

Then you can start Kodi with the reset button if you are in ES main screen.

xdeymos

Caution with saves !! Batocera5.21 had default the quickshutdown but DONT SAVE, the psx, snes, etc memory card.

You need shutdown from the menu (slow shutdown), for save your memory card.

(with batocera 5.20 and the script from retroflag i dont have any problem in the past...)

xdeymos

[deleted] one question.

I erased the 5.21 default script for retroflag, because dont save the games savefiles.

I put you script and Your script run fine but dont save the game save files when shut down with swich.

BUT if i push reset button on emulador i can go to main emulador page and YES save the gamedata saves... ITS FANTASTIC. BUT i only need fix the same when i shutdowh with the swich case (quick shut down)

[deleted]

xdeymos This is not related to the script I wrote. It changes just the behaviour of the reset button only. The shutdown button works as usual with the shutdown -h now call. So I see only the chance that a killall -w emulationstation command can be used (so it waits for an proper exit still all data is saved). Or I can surly add some code to the script. You may help me if you try the small fix within the python script.

As a small fix you can change the python script in L30 from

	os.system("shutdown -h now")

	os.system("/etc/init.d/S31emulationstation stop && sleep 5; shutdown -h now")

xdeymos

I going to try:

I have two archives IN SCRIPT FOLDER. "recalbox_SafeShutdown.py" and "recalbox_SafeShundown.sh"

In the ".py" i see that text:

#resets the pi
def reset():
while True:
GPIO.wait_for_edge(resetPin, GPIO.FALLING)
os.chdir(scriptDir)
output = int(subprocess.check_output(['./recalbox_SafeShutdown.sh', '--espid']))
output_rc = int(subprocess.check_output(['./recalbox_SafeShutdown.sh', '--emupid']))
if output_rc:
os.system(scriptDir + "/recalbox_SafeShutdown.sh --emukill")
elif output:
os.system(scriptDir + "/recalbox_SafeShutdown.sh --restart")
else:
os.system("shutdown -r now") I CHANGED THIS

This afternoon I have done many tests. WITH THE SAME RESULTS.... NO FIX TE PROBLEM..
And with your script, change the behavior of the reset button. But it does not lose the saved data.

The tests that I have done are:
1 I enter Game, and I create save file.
2 Pulse RESET (with your script I leave the game and return to the emulator)
3 I enter the game again. And the data is still saved even.
4. I turn off with the switch.
5. I turn on and the file is saved.

However, if I do NOT use the reset button:
1 I come into play. I create save file.
2 I turn off with the switch.
3 I turn on and the save file DISAPPEARS.

This did not happen to me with version 5.20 and the other script. It happens to me only with the 5.21 in any emulator.

NOTA IMPORTANT: With save states (hotkey + X , Y etc) any problem. Not important how swich off.

But for the game saves on memory cards, always lost if i use the swich off.

[deleted]

I can fix this.
It is because if you press powerdown then the emulator and ES is active in background. So to proper save savegames you have to terminate the emulator first!

Then you can shutdown ES. I need some make some changes to the python script then this will work 😉

def poweroff():
	while True:
		GPIO.wait_for_edge(powerPin, GPIO.FALLING)
                os.system("shutdown -h now")

must be changed to

def poweroff():
	while True:
		GPIO.wait_for_edge(powerPin, GPIO.FALLING)
                os.chdir(scriptDir)
 		output_rc = int(subprocess.check_output(['./recalbox_SafeShutdown.sh', '--emupid']))
 		if output_rc:
			os.system(scriptDir + "/recalbox_SafeShutdown.sh --emukill")
                        os.system("/etc/init.d/S31emulationstation stop && sleep 5; shutdown -h now")
                else:
                        os.system("shutdown -h now")

This will fix your savegame issue. Take care about the idents

xdeymos

Not RUN.

Now we have a different problem.

1 I come into play. I create save file.
2 I turn off with the switch.
3 The game exit and comeback to selector menu
4. The red light blinker and blinker forever
5. Never power off the system..... I am waiting 5 min, and only i see bliking the red light, and i dont put off. i can select other games or systems.

THIS IS MY ORIGINAL TEXT ARCHIVE:

#waits for user to hold button up to 1 second before issuing poweroff command
def poweroff():
while True:
GPIO.wait_for_edge(powerPin, GPIO.FALLING)
os.system("shutdown -h now")

AND I CHANGED FOR:

#waits for user to hold button up to 1 second before issuing poweroff command
def poweroff():
while True:
GPIO.wait_for_edge(powerPin, GPIO.FALLING)
os.chdir(scriptDir)
output_rc = int(subprocess.check_output(['./recalbox_SafeShutdown.sh', '--emupid']))
if output_rc:
os.system(scriptDir + "/recalbox_SafeShutdown.sh --emukill")
else:
os.system("shutdown -h now")
#blinks the LED to signal button being pushed
def ledBlink():
while True:
GPIO.output(ledPin, GPIO.HIGH)
GPIO.wait_for_edge(powerPin, GPIO.FALLING)
start = time.time()
while GPIO.input(powerPin) == GPIO.LOW:
GPIO.output(ledPin, GPIO.LOW)
time.sleep(0.2)
GPIO.output(ledPin, GPIO.HIGH)
time.sleep(0.2)

[deleted]

xdeymos I made changes to post above.... Try again.
Post comments regarding code always in ```
This will make code reading clearer

xdeymos

[deleted] I made changes to post above.... Try again.
Post comments regarding code always in ```
This will make code reading clearer

Sorry but not RUN. Dont fix the problem.

[deleted]

Then learn how python idents work

xdeymos

I dont understand your last answer.... I dont have idea about python... i try to help . Sorry if i disturb you.
The last changes in your code not run.

Thank you againg. I play and "save" with reset button before swich off.

(NOTE: if you mark a game "favorite" is similar (the same problem) , if shutdown with swich NO SAVE.
If mark favorite.. go to other game, and use reset to exit, the changes saves forever.....

Good night . See you later

[deleted]

xdeymos Python needs right spaces to work properly

This example will work

var=1
if var:
    print("Hello World") 
else:
    print("Nothing to do!")
print ("This is the end")

This example does not work

var=1
if var:
print("Hello World") 
else:
print("Nothing to do!")
print ("This is the end")

Do you see the difference? Every logic codeblock needs proper identations to work. Usually it's 4 spaces per codeblock, you can also use tabs. That's a needed ingredence in python language ... some may laugh about this but it's a common feature for better code reading to insert spaces for each logical codeblock.

In other language like C for example it really does not matter how your code style looks like.

EDIT:
Here you can play a bit with python online

[deleted]

xdeymos I made some changes to the script. Please reinstall with wget -O - "https://raw.githubusercontent.com/crcerror/retroflag-picase/master/install_batocera.sh" | bash

xdeymos

overwrited, with putty. Thank you for your time.

The problem dont FIX. If you are in a game , or mark a favorite game. If you shutdown with swich power off,
dont save the changes.
(swich on again, and no game saves, and no favorites marked).

Only save the changes with reset button. or shutdown (slow) from batocera menu.

NOTE NEW feature: If i play a game, save game, and exit using hotkey+start, come back to menu, and next shutdown with a swich , YES SAVE THE CHANGES. But need exit from emulador first.

[deleted]

xdeymos Thank you for your help. I made some changes again. I'm still on Batocera 5.20 and you're right in 5.21 there were some changes. So I changed the code logic a bit.

xdeymos

Ok, i download again (overwrited), and the results are:

The other version is better than this. Because:
If you are in a game , or mark a favorite game. If you shutdown with swich power off,
dont save the changes.

(swich on again, and no game saves, and no favorites marked).

Only save the changes with reset button. or shutdown (slow) from batocera menu.

NOTE NEW problem: If i play a game, save game, and exit using hotkey+start, come back to menu, and next shutdown with a swich , batocera NEVER SHUTDOWN, only red light blinking and a message "wait please".

NOTE NEW2: From batocera emustation, we cant shut down with the swich off.... BUT VERY IMPORTANT, you can do a quick shutdown if you are running any emulador. But from emustation the shutdown are slow, 5 min or more.

[deleted] Can you upload the before version? (i forgot do backup)

[deleted]

I reverted back. I need to take a deeper look but as I wrote in the first statement this means an issue due Batocera.

xdeymos

Ok. Thank [deleted] , this is the best versión for batocera and retroflag case.

[deleted]

I finally made it work.
So you can use power button to during running emulators and you won't loose game progress (by SRM states) or metadata.

It was a bit fuzzy to get this working.

xdeymos

Hello cyperghost. Thank you again.

I tested your last version yesterday. Works fine , but have a last problem. When shutdown with swich, the shutdown mode is slow. Need 2-3 min for off (blinking the led).

In your previus version, the shutdown is only 2-5 seconds. (I prefer that)

[deleted]

xdeymos I added now sigterm to some emulators that do not respond within 3 seconds. Maybe that was the problem here. Would be glad if you report back.

« Previous Page Next Page »