RetroFlag case - Advanced Safe Shutdown

xdeymos

Not RUN.

Now we have a different problem.

1 I come into play. I create save file.
2 I turn off with the switch.
3 The game exit and comeback to selector menu
4. The red light blinker and blinker forever
5. Never power off the system..... I am waiting 5 min, and only i see bliking the red light, and i dont put off. i can select other games or systems.

THIS IS MY ORIGINAL TEXT ARCHIVE:

#waits for user to hold button up to 1 second before issuing poweroff command
def poweroff():
while True:
GPIO.wait_for_edge(powerPin, GPIO.FALLING)
os.system("shutdown -h now")

AND I CHANGED FOR:

#waits for user to hold button up to 1 second before issuing poweroff command
def poweroff():
while True:
GPIO.wait_for_edge(powerPin, GPIO.FALLING)
os.chdir(scriptDir)
output_rc = int(subprocess.check_output(['./recalbox_SafeShutdown.sh', '--emupid']))
if output_rc:
os.system(scriptDir + "/recalbox_SafeShutdown.sh --emukill")
else:
os.system("shutdown -h now")
#blinks the LED to signal button being pushed
def ledBlink():
while True:
GPIO.output(ledPin, GPIO.HIGH)
GPIO.wait_for_edge(powerPin, GPIO.FALLING)
start = time.time()
while GPIO.input(powerPin) == GPIO.LOW:
GPIO.output(ledPin, GPIO.LOW)
time.sleep(0.2)
GPIO.output(ledPin, GPIO.HIGH)
time.sleep(0.2)

[deleted]

xdeymos I made changes to post above.... Try again.
Post comments regarding code always in ```
This will make code reading clearer

xdeymos

[deleted] I made changes to post above.... Try again.
Post comments regarding code always in ```
This will make code reading clearer

Sorry but not RUN. Dont fix the problem.

[deleted]

Then learn how python idents work

xdeymos

I dont understand your last answer.... I dont have idea about python... i try to help . Sorry if i disturb you.
The last changes in your code not run.

Thank you againg. I play and "save" with reset button before swich off.

(NOTE: if you mark a game "favorite" is similar (the same problem) , if shutdown with swich NO SAVE.
If mark favorite.. go to other game, and use reset to exit, the changes saves forever.....

Good night . See you later

[deleted]

xdeymos Python needs right spaces to work properly

This example will work

var=1
if var:
    print("Hello World") 
else:
    print("Nothing to do!")
print ("This is the end")

This example does not work

var=1
if var:
print("Hello World") 
else:
print("Nothing to do!")
print ("This is the end")

Do you see the difference? Every logic codeblock needs proper identations to work. Usually it's 4 spaces per codeblock, you can also use tabs. That's a needed ingredence in python language ... some may laugh about this but it's a common feature for better code reading to insert spaces for each logical codeblock.

In other language like C for example it really does not matter how your code style looks like.

EDIT:
Here you can play a bit with python online

[deleted]

xdeymos I made some changes to the script. Please reinstall with wget -O - "https://raw.githubusercontent.com/crcerror/retroflag-picase/master/install_batocera.sh" | bash

xdeymos

overwrited, with putty. Thank you for your time.

The problem dont FIX. If you are in a game , or mark a favorite game. If you shutdown with swich power off,
dont save the changes.
(swich on again, and no game saves, and no favorites marked).

Only save the changes with reset button. or shutdown (slow) from batocera menu.

NOTE NEW feature: If i play a game, save game, and exit using hotkey+start, come back to menu, and next shutdown with a swich , YES SAVE THE CHANGES. But need exit from emulador first.

[deleted]

xdeymos Thank you for your help. I made some changes again. I'm still on Batocera 5.20 and you're right in 5.21 there were some changes. So I changed the code logic a bit.

xdeymos

Ok, i download again (overwrited), and the results are:

The other version is better than this. Because:
If you are in a game , or mark a favorite game. If you shutdown with swich power off,
dont save the changes.

(swich on again, and no game saves, and no favorites marked).

Only save the changes with reset button. or shutdown (slow) from batocera menu.

NOTE NEW problem: If i play a game, save game, and exit using hotkey+start, come back to menu, and next shutdown with a swich , batocera NEVER SHUTDOWN, only red light blinking and a message "wait please".

NOTE NEW2: From batocera emustation, we cant shut down with the swich off.... BUT VERY IMPORTANT, you can do a quick shutdown if you are running any emulador. But from emustation the shutdown are slow, 5 min or more.

[deleted] Can you upload the before version? (i forgot do backup)

[deleted]

I reverted back. I need to take a deeper look but as I wrote in the first statement this means an issue due Batocera.

xdeymos

Ok. Thank [deleted] , this is the best versión for batocera and retroflag case.

[deleted]

I finally made it work.
So you can use power button to during running emulators and you won't loose game progress (by SRM states) or metadata.

It was a bit fuzzy to get this working.

xdeymos

Hello cyperghost. Thank you again.

I tested your last version yesterday. Works fine , but have a last problem. When shutdown with swich, the shutdown mode is slow. Need 2-3 min for off (blinking the led).

In your previus version, the shutdown is only 2-5 seconds. (I prefer that)

[deleted]

xdeymos I added now sigterm to some emulators that do not respond within 3 seconds. Maybe that was the problem here. Would be glad if you report back.

[deleted]

@xdeymos Minutes to shut down? I'm using the exact same script on my mashine and it works flawless. Does this behaviour accour at every run?
So you power on, wait for ES be booted and then power off with switch?
Or does it only occour if you switch off during an running emulator?

xdeymos

Hello [deleted] this afternoon i will test your last script. I tell you the feedback soon..

xdeymos

I need about 15 days to be able to do the tests. I'm moving. (change of address) and my raspberry is packed in a box
🙁 . When it's available, I'll test your latest version.

By the way, the slow shutdown happened to me by pressing the button off, while playing a game of SNES

[deleted]

xdeymos Please do so

xdeymos

Is better the previous version. On your last version , i test with Snes. Zelda a link to the past. Im playing and swich off. Batocera exit game, exit emulador, and next go to off. But the problem is swich off slow mode . No fast shutdown.

3-4 min to off.

I prefer the other

[deleted]

xdeymos I installed the script on a fresh Batocera 5.22 version. Works like it should.... Reset button works, Power off works (LED blinks) and at last the power cut off. I don't know what's wrong here 🙁

« Previous Page Next Page »