Compile a Linux module for current (5.25) batocera?

3615ulla

Hello,

I have a dual Wii Classic Controller to PC USB Adapter which isn't quite supported (I posted the gory details on reddit). I suspect it's a Linux issue and I need to add the VID/PID of my adapter to the hid_sjoy.c module to get both ports working. Right now, only one is working.

Could you kindly let me know which github branch/revision of batocera.linux buildroot corresponds to the current 5.25 version? I think I did manage compile a modified linux module through buildroot br2-external after modifying the x86_64 config to use Linux 5.4.16, but I couldn't insmod the resulting module on my batocera box. Any additional help and instructions welcome!

Thank you very much :-)

EDIT: The batocera.linux "5.25_fixes" git branch would be a good start to start messing with modules for 5.25...

"The files are in the computer. So simple!"

3615ulla

It worked! My new hid-sjoy.ko module is definitely picking up my adapter now and gives me two inputs which I can map to player1 / player2 in the UI :-)

But! I may have messed my axis quirks as both the cross buttons and analog sticks seem to be mapped to the same axis.

EDIT: OK, the second pad is definitely stuck in the wrong mode at boot-up. From the docs: 3 different modes for D-Pad: POV mode,Button Mode, and X/Y Analog Axis mode, accessible by pressing and holding “Home” and “L” or “R”. Cycling through the modes on the second pad gets to one where the Main menu can be navigated with both the D-Pad and the Left joystick. Not sure if there’s anything I can do about that, but if I do, I’ll report back.

For now in my hid-quirks.c:

static const struct hid_device_id hid_quirks[] = {
...
	{ HID_USB_DEVICE(USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_DUAL_WII_CLASSIC), HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },

HID_QUIRK_MULTI_INPUT is 0×00000040 and HID_QUIRK_NOGET is 0×00000008 … No idea what HID_QUIRK_NOGET does but other multi-input adapters by USB_VENDOR_ID_WISEGROUP have it set.

For reference, here are the steps I took so far (so I don’t forget them):

git clone https://github.com/batocera-linux/batocera.linux
cd batocera.linux
git checkout 5.25_fixes
make clean
make batocera-x86_64_defconfig
make -j4 linux

then add the new device id in hid-ids.h:

#define USB_VENDOR_ID_WISEGROUP		0x0925
#define USB_DEVICE_ID_SMARTJOY_PLUS	0x0005
#define USB_DEVICE_ID_SUPER_JOY_BOX_3	0x8888
#define USB_DEVICE_ID_QUAD_USB_JOYPAD	0x8800
#define USB_DEVICE_ID_DUAL_USB_JOYPAD	0x8866
//add this:
#define USB_DEVICE_ID_DUAL_WII_CLASSIC  0x03E8

and find where to put the following in hid-sjoy.c:

	{ HID_USB_DEVICE(USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_DUAL_WII_CLASSIC),
		.driver_data = HID_QUIRK_MULTI_INPUT |
			       HID_QUIRK_SKIP_OUTPUT_REPORTS },

, then

make -j4 linux-rebuild

I ensured the module_layout matched the existing modules in my working batocera:

modprobe --dump-modversions output/target/lib/modules/5.4.16/kernel/drivers/hid/hid-sjoy.ko | grep module_layout
0xa2d12933      module_layout

I then copied over my new hid-sjoy.ko in output/target/lib/modules/5.4.16/kernel/drivers/hid to my working batocera, in /lib/modules/5.4.16/kernel/drivers/hid … and checked that things work by doing:

# lsusb
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 012: ID 03f0:354a HP, Inc
Bus 001 Device 018: ID 0925:03e8 Lakeview Research Wii Classic Controller Adapter
Bus 001 Device 002: ID 05e3:0608 Genesys Logic, Inc. Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

# insmod /lib/modules/5.4.16/kernel/drivers/hid/hid-sjoy.ko
# lsmod | grep hid
hid_sjoy               20480  0
ff_memless             20480  1 hid_sjoy
hid_generic            16384  0
usbhid                 65536  0
hid                   143360  3 hid_sjoy,hid_generic,usbhid
mac_hid                16384  0

# tail /var/log/messages
Mar 29 20:05:00 batocera user.info kernel: [260471.688701] usb 1-3.1: USB disconnect, device number 19
Mar 29 20:05:02 batocera user.info kernel: [260473.977045] usb 1-3.1: new low-speed USB device number 20 using xhci_hcd
Mar 29 20:05:02 batocera user.info kernel: [260474.085041] usb 1-3.1: New USB device found, idVendor=0925, idProduct=03e8, bcdDevice= 1.00
Mar 29 20:05:02 batocera user.info kernel: [260474.085048] usb 1-3.1: New USB device strings: Mfr=1, Product=2, SerialNumber=0
Mar 29 20:05:02 batocera user.info kernel: [260474.085052] usb 1-3.1: Product: Mayflash Wii Classic Controller
Mar 29 20:05:02 batocera user.info kernel: [260474.085056] usb 1-3.1: Manufacturer: Mayflash.,Ltd
Mar 29 20:05:02 batocera user.info kernel: [260474.097731] input: Mayflash.,Ltd Mayflash Wii Classic Controller as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3.1/1-3.1:1.0/0003:0925:03E8.0012/input/input30
Mar 29 20:05:02 batocera user.info kernel: [260474.157178] input: Mayflash.,Ltd Mayflash Wii Classic Controller as /devices/pci0000:00/0000:00:14.0/usb1/1-3/1-3.1/1-3.1:1.0/0003:0925:03E8.0012/input/input31
Mar 29 20:05:02 batocera user.info kernel: [260474.157480] smartjoyplus 0003:0925:03E8.0012: input,hidraw0: USB HID v1.01 Joystick [Mayflash.,Ltd Mayflash Wii Classic Controller] on usb-0000:00:14.0-3.1/input0
Mar 29 20:05:02 batocera user.info kernel: [260474.157505] smartjoyplus 0003:0925:03E8.0012: Force feedback for SmartJoy PLUS PS2/USB adapter

# ls /dev/input/js*
/dev/input/js0  /dev/input/js1

TODO: I see batocera already patches hid-quirks.c for quite a few joysticks, I’ll see if I can add my own changes to your patch.

EDIT: Batocera uses overlayfs. Let’s see if I got this right (all typed from my batocera box):

# mount -o remount,rw /
# scp 3615ulla@devel-box:/home/3615ulla/projects/batocera.linux/output/target/lib/modules/5.4.16/kernel/drivers/hid/hid-sjoy.ko /lib/modules/5.4.16/kernel/drivers/hid/
# /usr/bin/batocera-save-overlay
Making /boot writable...
Mounting the overlay file...
Saving the real overlay to disk...
sending incremental file list
./
etc/hosts
lib/
lib/modules/
lib/modules/5.4.16/
lib/modules/5.4.16/kernel/
lib/modules/5.4.16/kernel/drivers/
lib/modules/5.4.16/kernel/drivers/hid/
lib/modules/5.4.16/kernel/drivers/hid/hid-sjoy.ko
usr/share/X11/xkb/compiled/
usr/share/batocera/
usr/share/batocera/datainit/
usr/share/batocera/datainit/cheats/
usr/share/batocera/datainit/cheats/cht/
usr/share/batocera/datainit/cheats/cht/FinalBurn Neo/
usr/share/fonts/X11/100dpi/
usr/share/fonts/X11/75dpi/
usr/share/fonts/X11/cyrillic/
usr/share/fonts/X11/encodings/large/
var/run/utmp

sent 9,142 bytes  received 161 bytes  18,606.00 bytes/sec
total size is 8,900  speedup is 0.96
Umounting the overlay file...
Making /boot read only...
Synchronizing...
Success.

For some reason, I also had to add the following line to /etc/modules.conf (and save the overlay), otherwise the adapter was just picked-up by hid-generic on reboot:

hid-sjoy

It’s all working now! If you see anything I could’ve done better, do let me know :-)

liOnux33

Hi 3615ulla ,
Good job !
And maybe you can help me :
I have 2 Playstation2 controllers with a USB adapter.
I can't use them for Batocera because the hid-sony driver doesn't map PS2 buttons correctly since kernel 4.10.
The solution by Silver-X is here:
https://www.linuxquestions.org/questions/linux-games-33/playstation2-controller-with-usb-adapter-need-help-getting-additional-buttons-to-work-4175643583/
It works with my Zorin OS but I'm not sure I have the skills for Batocera.
I'll try, but if you can guide me, it will be easier for me ;-)
See you soon
Lionel

3615ulla

Hey Lionel, sorry I just checked my account this morning, oops! :-)

Exactly what is the USB converter you have? The one I bought from Liksang (a couple of years ago at least) might be PS1 only. What does lsusb give you?

So looking through the thread you linked, basically what these people did is to take the 4.9 working hid-sony module and compile it with a more up to date version of the kernel (4.10). The module source code for hid-sony.c and hid-sony.h is in this zip that was linked in the thread: https://sites.google.com/site/panicus/Sony-HID-Downgrader.zip

You could follow my steps after overwriting the current hid-sony.c / hid-sony.h in your kernel_source/drivers/hid/ with the ones from this zip.

if after "make -j4 linux-rebuild" you have a file called output/target/lib/modules/5.4.16/kernel/drivers/hid/hid-sony.ko, you're all set to try it out!

No idea whether this will work or not. The proper way would be to diff the .c / .h files and try and understand where the bug was introduced.

Let me know if the overwrite method helps or not.

Cheers :-)

liOnux33

Hi 3615ulla !

lsusb gives this :
Bus 002 Device 005: ID 054c:0268 Sony Corp. Batoh Device / PlayStation 3 Controller

I will try to compile this night ;-)

See you soon,
Lionel

PS : 3615ulla is from french minitel ?

3615ulla

Hey Lionel,

the nickname is from a 90s French song. I don't know if you know it, but it made me smile ear to ear when it first came out... a few years ago, was it? ;-)

I just had a look at the manufacturer id / device ID you gave me: https://wiki.gentoo.org/wiki/Sony_DualShock -- Says DualShock 3 / Sixaxis ? Is your USB converter pretending to be a DualShock 3? Very strange!

But that "sixaxis" thing made me think...

I did a diff between the two files and they're not that different, but there's a missing static u8 sixaxis_rdesc[] in the new one... I think the code may have been reorganised at some point and some buttons from the Sixaxis fell through the cracks.

Let me know if you do manage to compile the old module, I'm a lot more optimistic than I was this morning.

Bonne nuit man, bon confinement :-)

liOnux33

Thanks a lot for your help 3615ulla (I love it : "C'est toi que je t'aime (Vachement beaucoup)" 1992, Les Inconnus ;-))

So... I think I did wrong:
Since I don't know how to use Docker, I did this:
git clone https://github.com/batocera-linux/batocera.linux.git cd batocera.linux git submodule init git submodule update make O=$PWD/output/x86_64 BR2_EXTERNAL=$PWD -C $PWD/buildroot batocera-x86_64_defconfig

After about 12 hours (!), the compilation was stopped by an error: Failed to download "kodi-superrepo-repositories 0.7.04".

And on the other hand, when do I have to overwrite the hid-sony sources ?

Bon courage également pendant ce confinement ! 😉

3615ulla

Hey Lionel,

I think you forgot to checkout the 5.25_fixes branch, check my instructions above ;-)

git clone https://github.com/batocera-linux/batocera.linux
cd batocera.linux
git checkout 5.25_fixes
make clean
make batocera-x86_64_defconfig
make -j4 linux

Here's a link to one I compiled for you, let me know if it at least works so you don't have to struggle on for another 12 hours :-)

liOnux33

Hi 3615ulla,
After git clone https://github.com/batocera-linux/batocera.linux
and
cd batocera.linux
git checkout 5.25_fixes gives an error : unknown git file
For instancegit checkout master is OK
but make clean gives Makefile:18: *** "docker not found!"
same result formake batocera-x86_64_defconfig gives Makefile:18: *** "docker not found!"

😓

3615ulla

Oh no!

It looks like that branch I was using is now gone or was merged back. Shame a batocera-5.25 tag wasn't created...

Anyway, the first line when I do git log --oneline is:

b0652e6842 (HEAD -> 5.25_fixes, origin/5.25_fixes) Merge pull request #1355 from Genetik57/cleaning-batocera_conf

Does that help at all? Sorry, I don't know git, only super basic usage 😓

liOnux33

3615ulla
Hi 3615ulla,

Hurrah !!! After hours and hours of reading and translating (I’m not very good in English…) of Docker, Git and Linux compilation and after some trials and errors, I finally managed to use my old PS2 controllers with Batocera :-))
I will open another post to explain my procedure but what I can already say is that there is no need to find a Git branch with the kernel used in Batocera : I chose “Custom kernel” and typed “5.4.16” in make linux-menuconfig !

In any way, thank-you very much 3615ulla
Lionel

liOnux33

My issue is solved 😀

3615ulla

Sorry Lionel, just saw this!

I was hoping my message to the general board about the 5.25 github tag would’ve gotten an answer, but it didn’t / hasn’t yet (there’s always hope). https://forum.batocera.org/d/3705-git-tag-for-batocera-525

So you managed to sort yourself out and even wrote a tutorial? That’s amazing! Did you see the last few steps of what I wrote about overlayfs to make your changes “stick”? Hope this helped.

By the way, I got this one for my Gamecube controllers: https://www.aliexpress.com/item/4000562126493.html – It’s arrived but I haven’t had a chance to test it yet with Batocera. I see more trouble in my future..

Have fun and remember Batocera IS the game ;-)

liOnux33

3615ulla

Yes you’re right, it’s necessary to run the script batocera-save-overlay to make the new module persistent on every reboot. Thanks 🙂
Here, my tutorial :
https://forum.batocera.org/d/3796-tuto-make-your-ps2-controller-works-completely-with-a-cheap-usb-adaptor/

EDIT : Scott Shumate just proposed a patch to LKLM here : https://lkml.org/lkml/2020/5/13/1323

Cheers @3615ulla
👍 👍 👍

barnw0l

hey 3615ulla thank you for making this thread. I have the same Wii adapter and it’s hard to find any info. Would message you if I could as I’m not using Batocera. I am trying to get this adapter working for 2 controllers in Ubuntu. They are acting just as you described initially. They are loaded with hid-generic even after having the system load hid-sjoy at boot. Is that a problem? Maybe I can just tell hid-generic to treat the device ID as 2 controllers and not 1. That’s all you had to do in hid-sjoy.c, right? Do you still have the changes you made to that file?

I’m using fighsticks (nothing actually analog) so the hid-quirks stuff won’t be an issue.

3615ulla

Sorry @barnw0l, I dropped the ball on this, didn’t I?

All I was able to do was to dig my kernel source with the changes I talked about (check the differences with the .bak original files included in the zip): https://www.dropbox.com/s/lvvgxip8v1sfv6l/my_hid.zip?dl=0

EDIT Reading your post again, you mentioned not using Batocera. You should be all set with the zip above and I also updated my first (or second) message to show where what goes where a bit better.

Let me know how you’re getting on and if you get a chance to put it all back together, do let me know. The multiple lockdowns we’ve gone through have left me a lot dumber than I used to remember I was :-)

~~I haven’t tried any of this on a recent version of Batocera though. I was waiting for a replacement computer to play with and… I got distracted with other things.~~

~~@liOnux33 wrote a tutorial which may also be useful: https://forum.batocera.org/d/3796-tuto-make-your-ps2-controller-works-completely-with-a-cheap-usb-adaptor~~

Stay safe mate!

barnw0l

for future generations:

Just sat down at this finally, and didn’t take much time. Some searching related to 3615ulla ’s files brought me to this solution. All Ubuntu needed to see this as two controllers was adding the following to GRUB_CMDLINE_LINUX_DEFAULT in /etc/default/grub:

usbhid.quirks=0×0925:0×03e8:0×040

Apparently it’s a typical Linux “quirk” when two controllers are using one USB.

Cheers!

barnw0l

Thanks so much @3615ulla I should be able to sort this out now, next crack at it